Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amb 1748 create unit tests for validations 10 to 19 #59

Merged
merged 57 commits into from
Dec 22, 2023
Merged

Amb 1748 create unit tests for validations 10 to 19 #59

merged 57 commits into from
Dec 22, 2023

Conversation

AlexandraBenson
Copy link
Contributor

Summary

  • Routine Change
  • ❗ Breaking Change
  • 🤖 Operational or Infrastructure Change
  • ✨ New Feature
  • ⚠️ Potential issues that might be caused by this change

Add any other relevant notes or explanations here. Remove this line if you have nothing to add.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

root and others added 30 commits November 28, 2023 17:26
Add some unit tests and update validators
ea74494
Add model invalid report origin text test
d46179c
Resolve conflicts and merge master into validations branch
808845a
Split out validator tests into method and model tests
98bd76d
Add pre-validation for disease type
971c9d5
@nathanwall
fix validate_recorded in CSV
2de4f81
@nathanwall
check if report origin is not a NoneType
d5cb275
@nathanwall
updated error message for report origin text
fd7f9ed
@nathanwall
Start work on pre-validators
7f8cfa6
Add patient name and name_given tests and update validators and add p…
206c74b 
…ractitioner validator and test files
Merge branch 'master' into AMB-1748-create-unit-tests-for-validations…
e40f92b 
…-10-to-19
Add validators and tests for patient family name and birth date and e…
5754180 
…xtract generic validation code into utils
Add validators and tests for gender, address and address_postal_code …
869e6c4 
…and add clarity to docstrings
Add occurrenceDateTime pre validator and tests
02ca91e
@nathanwall
validators and tests for fields 8 to 10
67bd9d2
Add test utils file and generic string validation tests methods
c86cb4b
Amend immunization pre validator methods tests to use generic test fu…
e27d37a 
…nctions
Amend patient pre validator method tests to use generic functions
8276931
@nathanwall
Create generic model tests
f3157ac
Add checking of empty string for fields with defined length and fix i…
01455b1 
…nadvertent changing of lists to tuples
@nathanwall
Fix tests and move old code to 'old'
62ed0a9
Add empty list test to generic list test and use generic test functio…
7e69ad1 
…ns for occurrenceDateTime
Merge branch 'AMB-1748-create-unit-tests-for-validations-10-to-19' of h…
04de9bc 
…ttps://github.com/NHSDigital/immunisation-fhir-api into AMB-1748-create-unit-tests-for-validations-10-to-19
Amend patient model tests to use generic functions
77958cf
@nathanwall
fix for mesh csv test
444d729
@AlexandraBenson
Amend patient model tests to use generic functions
46a733e
@AlexandraBenson
Rename old files, add status validator and tests
e6affe1
@AlexandraBenson
Add validators and tests for items 12 - 16
df27499
@AlexandraBenson
Add all remaining validators and tests for 1-19
6a27eb9
@AlexandraBenson
Tidy up
f516355
@github-actions GitHub Actions
Copy link
Contributor

This branch is work on a ticket in the NHS Digital VTX JIRA Project. Here's a handy link to the ticket:

@github-actions GitHub Actions
Copy link
Contributor

This branch is work on a ticket in the NHS Digital VTX JIRA Project. Here's a handy link to the ticket:

@github-actions GitHub Actions
Copy link
Contributor

This branch is work on a ticket in the NHS Digital VTX JIRA Project. Here's a handy link to the ticket:

@github-actions GitHub Actions
Copy link
Contributor

This branch is work on a ticket in the NHS Digital VTX JIRA Project. Here's a handy link to the ticket:

@github-actions GitHub Actions
Copy link
Contributor

This branch is work on a ticket in the NHS Digital VTX JIRA Project. Here's a handy link to the ticket:

@github-actions GitHub Actions
Copy link
Contributor

This branch is work on a ticket in the NHS Digital VTX JIRA Project. Here's a handy link to the ticket:

lee-richardson-nhs
lee-richardson-nhs reviewed Dec 18, 2023
View reviewed changes
lambda_code/src/models/utils.py Show resolved Hide resolved
lambda_code/src/models/utils.py Show resolved Hide resolved
lambda_code/src/models/utils.py Show resolved Hide resolved
lambda_code/src/models/utils.py Show resolved Hide resolved
lambda_code/src/models/utils.py Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

This branch is work on a ticket in the NHS Digital VTX JIRA Project. Here's a handy link to the ticket:

@github-actions GitHub Actions
Copy link
Contributor

This branch is work on a ticket in the NHS Digital VTX JIRA Project. Here's a handy link to the ticket:

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

This branch is work on a ticket in the NHS Digital VTX JIRA Project. Here's a handy link to the ticket:

@github-actions GitHub Actions
Copy link
Contributor

This branch is work on a ticket in the NHS Digital VTX JIRA Project. Here's a handy link to the ticket:

@AlexandraBenson AlexandraBenson merged commit 607324a into master Dec 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lee-richardson-nhs lee-richardson-nhs lee-richardson-nhs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexandraBenson @lee-richardson-nhs @nathanwall