feat: Set record insert and updated datetimes for historical records #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamTyrrellNHS
previously approved these changes
Jan 24, 2025
SamTyrrellNHS
previously approved these changes
Jan 24, 2025
...ticsManagementService/CreateParticipantScreeningEpisode/CreateParticipantScreeningEpisode.cs
Outdated
Show resolved
Hide resolved
|
Just a couple of SonarQube issues to check |
...ticsManagementService/CreateParticipantScreeningProfile/CreateParticipantScreeningProfile.cs
Outdated
Show resolved
Hide resolved
...ticsManagementService/CreateParticipantScreeningEpisode/CreateParticipantScreeningEpisode.cs
Outdated
Show resolved
Hide resolved
...ticsManagementService/CreateParticipantScreeningProfile/CreateParticipantScreeningProfile.cs
Outdated
Show resolved
Hide resolved
...ticsManagementService/CreateParticipantScreeningEpisode/CreateParticipantScreeningEpisode.cs
Outdated
Show resolved
Hide resolved
...ticsManagementService/CreateParticipantScreeningEpisode/CreateParticipantScreeningEpisode.cs
Outdated
Show resolved
Hide resolved
…addressed other comments
|
alex-clayton-1
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a functionality in the Create PS Episode and Profile functions (Management Service) that determines whether incoming participant data or episode data is historic. The historic date cut off is the 1st of March 2025 for now (based on go live estimates). If the data is historic, the RECORD INSERT DATE TIME and RECORD UPDATE DATE TIME dates are set to the episode/participant's SrcSysProcessedDateTime +1 day. If they are NOT Historic then they are set to DateTime.Now
I rescaffolded
Did not think that unit tests were applicable
Context
It ensures we have an accurate Record Insert and Update Date Time that reflects the incoming data's relevance
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.