feat(page: detail): can add tags to item #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When I ran this application locally it threw errors.
Please make sure your changes are compatible with old data. |
|
ok i'll check it @wendzhue |
|
I'm busy recentlt, and check it on holiday online demo https://tirelyl.github.io/today-ng-steps/ |
wzhudev
reviewed
Oct 2, 2018
| @@ -11,6 +11,28 @@ | |||
| </div> | |||
| <label nz-checkbox (click)="$event.stopPropagation()" [(ngModel)]="currentTodo.completedFlag"></label> | |||
| <span>标记完成</span> | |||
| <nz-divider nzText="标签" nzOrientation="left"></nz-divider> | |||
There was a problem hiding this comment.
Tag has no superior priority to title and date. It should be placed after date and before description.
| *ngIf="!addTagInputVisible" | ||
| class="editable-tag" | ||
| (click)="showAddTagInput()"> | ||
| <i class="anticon anticon-plus"></i> New Tag |
There was a problem hiding this comment.
Use Chinese for now. i18n would be introduced later.
|
.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.