Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up cmake #17

Merged
merged 1 commit into from
Nov 30, 2023
Merged

clean up cmake #17

merged 1 commit into from
Nov 30, 2023

Conversation

weilewei
Copy link
Collaborator

This PR

  • rename nvstdpar to hpcpp in most places
  • remove magic_enum to address ticket remove magic_enum #10
  • move argparse to cpm instead of under externals folder to be consistent with rest of external libraries
  • since no files under externals folder, therefore empty it out

@weilewei weilewei mentioned this pull request Nov 30, 2023
Merged
mhaseeb123
mhaseeb123 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@mhaseeb123 mhaseeb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good

@mhaseeb123 mhaseeb123 merged commit 4bb2e94 into main Nov 30, 2023
@mhaseeb123 mhaseeb123 deleted the fix_cmake branch November 30, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhaseeb123 mhaseeb123 mhaseeb123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weilewei @mhaseeb123