Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace gateway with web component, in both vercel and web4 #484

Merged
merged 33 commits into from
Aug 1, 2024
Merged

Replace gateway with web component, in both vercel and web4 #484

merged 33 commits into from
Aug 1, 2024

Conversation

elliotBraem
Copy link
Contributor

@elliotBraem elliotBraem commented Jul 19, 2024 •
edited
Loading

  • tests and dev commands configured with web component
  • Use "Wallet" custom element
  • standardizes Login prompting
  • removes old gateway code
  • still supports deploy to vercel (modifies settings to basically just serve "public" directory)
  • supports deploy to web4 (handled through contract)

@vercel Vercel
Copy link

vercel bot commented Jul 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gateway ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 7:45pm

@elliotBraem
Copy link
Contributor Author

elliotBraem commented Jul 31, 2024 •
edited
Loading

You can see a successful deploy to vercel here: gateway-pq9z5a5uy-nearbuilders.vercel.app

Testnet web4 deploy here: https://builddao.testnet.page/

@elliotBraem elliotBraem reopened this Jul 31, 2024
@elliotBraem
Copy link
Contributor Author

Closing and reopening to trigger staging deploy

@elliotBraem elliotBraem changed the title Use web component for gateway Replace gateway with web component, in both vercel and web4 Jul 31, 2024
Megha-Dev-19
Megha-Dev-19 approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@Megha-Dev-19 Megha-Dev-19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Megha-Dev-19
Copy link
Collaborator

@race-of-sloths score 8

@race-of-sloths
Copy link

🌟 Score recorded!

@Megha-Dev-19, thank you for scoring this pull request in the Race of Sloths!

@elliotBraem elliotBraem merged commit 875eec9 into develop Aug 1, 2024
7 of 8 checks passed
@elliotBraem elliotBraem deleted the feat/use-wc-gateway branch August 1, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Megha-Dev-19 Megha-Dev-19 Megha-Dev-19 approved these changes

@itexpert120 itexpert120 Awaiting requested review from itexpert120 itexpert120 is a code owner

@Jikugodwill Jikugodwill Awaiting requested review from Jikugodwill Jikugodwill is a code owner

@saadiqbal-dev saadiqbal-dev Awaiting requested review from saadiqbal-dev saadiqbal-dev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elliotBraem @race-of-sloths @Megha-Dev-19