Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications page #288

Merged
merged 6 commits into from
May 13, 2024
Merged

Notifications page #288

merged 6 commits into from
May 13, 2024

Conversation

itexpert120
Copy link
Collaborator

Resolves #282

2024-05-09.07-58-33.mp4

@vercel Vercel
Copy link

vercel bot commented May 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gateway ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 8:47pm

elliotBraem
elliotBraem reviewed May 10, 2024
View reviewed changes
apps/builddao/widget/TrialAccountBanner.jsx Outdated Show resolved Hide resolved
apps/builddao/widget/app.jsx Outdated Show resolved Hide resolved
apps/builddao/widget/app/view.jsx Outdated Show resolved Hide resolved
apps/builddao/widget/logout.jsx Outdated Show resolved Hide resolved
apps/builddao/widget/page/notifications.jsx Outdated Show resolved Hide resolved
@Megha-Dev-19
Copy link
Collaborator

@itexpert120 quick question, do we show custom notifications? specially the builddao custom notification?

@itexpert120
Copy link
Collaborator Author

@itexpert120 quick question, do we show custom notifications? specially the builddao custom notification?

We can create custom notification and add support for it in our gateway

Megha-Dev-19
Megha-Dev-19 approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@Megha-Dev-19 Megha-Dev-19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please create a ticket to support custom notifications in the feed.
Left a comment
LGTM

apps/builddao/widget/page/notifications.jsx Outdated
Comment on lines 3 to 5
if (!accountId) {
return "Sign in with NEAR Wallet";
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we show a login button to navigate them to join page?
Like we do for feed I guess

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this sounds like a nice addition

@elliotBraem
Copy link
Contributor

@itexpert120 If we can resolve merge conflict, add the login button for join page when not logged in, and create the ticket for supporting custom notification for buildhub.near, this looks good to me!

@itexpert120
Copy link
Collaborator Author

Resolved

@elliotBraem elliotBraem merged commit 1acfc53 into develop May 13, 2024
4 checks passed
@elliotBraem elliotBraem deleted the notifications-page branch May 13, 2024 20:49
Megha-Dev-19 pushed a commit that referenced this pull request May 14, 2024
@itexpert120 @Megha-Dev-19
Notifications page (#288)
41d2b62 
* Useless fallback

* Add notifications page

* Resolve comments

* fmt

* Prompt for login on notifications page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliotBraem elliotBraem elliotBraem left review comments

@Megha-Dev-19 Megha-Dev-19 Megha-Dev-19 approved these changes

@Jikugodwill Jikugodwill Awaiting requested review from Jikugodwill Jikugodwill is a code owner

@saadiqbal-dev saadiqbal-dev Awaiting requested review from saadiqbal-dev saadiqbal-dev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add notifications page
3 participants
@itexpert120 @Megha-Dev-19 @elliotBraem