Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import project from potlock #283

Merged
merged 7 commits into from
May 12, 2024

Conversation

Megha-Dev-19
Copy link
Collaborator

@Megha-Dev-19 Megha-Dev-19 commented May 6, 2024

Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gateway ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 5:34pm

@Megha-Dev-19
Copy link
Collaborator Author

If anyone has better way of uploading files (more than 10mb), let me know, because currently you'll have to download it.
Also there is still one issue with the PR, after you search a project and enter, the text is cleaned, which ideally shouldn't be, since the widget has it's own state for storing the search term. I don't want to move it to parent, it will cause too much of rendering then. If anyone has any solution, I m all ears.

@itexpert120
Copy link
Collaborator

What about using props?

Copy link
Contributor

@elliotBraem elliotBraem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Looks great

<Component />
</Container>
);
// {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh shoot, I committed it, will revert, thanks for letting me know.

@Megha-Dev-19
Copy link
Collaborator Author

What about using props?

@itexpert120 Props how?

@elliotBraem elliotBraem merged commit da37ff5 into NEARBuilders:develop May 12, 2024
4 checks passed
saadiqbal-dev pushed a commit that referenced this pull request May 13, 2024
* reorder files and add some design updates

* added projects from potlock

* updated create modal to potlock project

* minor fixes

* minor fixes

* revert connect change

* fix tasks tab
Megha-Dev-19 added a commit that referenced this pull request May 14, 2024
* reorder files and add some design updates

* added projects from potlock

* updated create modal to potlock project

* minor fixes

* minor fixes

* revert connect change

* fix tasks tab
@Megha-Dev-19 Megha-Dev-19 deleted the project-import-potluck branch June 24, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import project from potlock
3 participants