Deploy type file and metadata to attestation registry #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corydickson
force-pushed
the
deploy-registry
branch
from
7cb23d1 to
cddf6ff
Compare
elliotBraem
reviewed
Apr 9, 2024
| const USE_DEFAULT_SIGNER_OPTIONS = true; | ||
| const getSignerOptions = () => | ||
| USE_DEFAULT_SIGNER_OPTIONS | ||
| ? ["sign-as", appAccount, "network-config", "testnet"] |
There was a problem hiding this comment.
Hard-coded testnet, can we have network passed through cli? Fine if it defaults to testnet
| .command("attest") | ||
| .description("Deploy the project with metadata") | ||
| .argument("[app_name]", "app name") | ||
| .argument("[type_file]", "type definition") |
There was a problem hiding this comment.
What is the type definition? How is it supposed to be provided?
| data: { | ||
| [appAccount]: JSON.parse(dataJSON), | ||
| metadata: {}, | ||
| types: JSON.parse(typeFile) |
There was a problem hiding this comment.
what if no typeFile provided, there isn't a default in the cli
| version: `${version ?? ""}`, | ||
| content_type: "ipfs", | ||
| cid: ipfsHash.toString(), | ||
| is_contract: true, |
There was a problem hiding this comment.
What does is_contract mean?
elliotBraem
reviewed
Apr 11, 2024
| @@ -1,4 +1,11 @@ | |||
| import { BaseConfig } from "./config"; | |||
| import { uploadAndPinJson } from '@archetype-org/ribbit'; | |||
There was a problem hiding this comment.
What if we moved all of this "deploy_with_metadata" to archetype library?
The attest command can be a direct mapping to ribbit and your contract.
-- although it appears that repo private. We're not sharing builds with a private api.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.