-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treasury self creation flow #102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't we need to have the same config, data and css for the self create flow, since it will be only one instance (not like the treasury dashboard)
can you also please add some screenshots or video, to display the UI, and also attach the ticket which it resolves.
thanks!
instances/treasury-factory.near/widget/components/OffCanvas.jsx
Outdated
Show resolved
Hide resolved
instances/treasury-factory.near/widget/components/ProfileAutocomplete.jsx
Outdated
Show resolved
Hide resolved
instances/treasury-factory.near/widget/components/create-treasury/SummaryStep.jsx
Outdated
Show resolved
Hide resolved
code refactoring
5120da3
to
571d903
Compare
6340508
to
9a5a128
Compare
c8fa540
to
0bb18f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few comments
instances/treasury-factory.near/widget/components/NewAccountInput.jsx
Outdated
Show resolved
Hide resolved
instances/treasury-factory.near/widget/components/create-treasury/AddMemberForm.jsx
Outdated
Show resolved
Hide resolved
instances/treasury-factory.near/widget/components/create-treasury/AddMemberForm.jsx
Outdated
Show resolved
Hide resolved
instances/treasury-factory.near/widget/components/create-treasury/AddMembersStep.jsx
Outdated
Show resolved
Hide resolved
instances/treasury-factory.near/widget/components/create-treasury/ConfirmWalletStep.jsx
Outdated
Show resolved
Hide resolved
instances/treasury-factory.near/widget/components/create-treasury/SummaryStep.jsx
Outdated
Show resolved
Hide resolved
@race-of-sloths include |
@rubycop Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 13! @Megha-Dev-19 received 25 Sloth Points for reviewing and scoring this pull request. Congratulations @rubycop! Your PR was highly scored and you completed another monthly streak! To keep your monthly streak make another pull request next month and get 8+ score for it What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@race-of-sloths score 13 |
No description provided.