Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treasury self creation flow #102

Merged
merged 14 commits into from
Nov 18, 2024
Merged

Treasury self creation flow #102

merged 14 commits into from
Nov 18, 2024

Conversation

rubycop
Copy link
Collaborator

@rubycop rubycop commented Oct 30, 2024

No description provided.

@rubycop rubycop requested a review from Megha-Dev-19 October 30, 2024 17:37
Copy link
Collaborator

@Megha-Dev-19 Megha-Dev-19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't we need to have the same config, data and css for the self create flow, since it will be only one instance (not like the treasury dashboard)
can you also please add some screenshots or video, to display the UI, and also attach the ticket which it resolves.
thanks!

code refactoring
@rubycop rubycop requested a review from Megha-Dev-19 October 31, 2024 19:48
@rubycop rubycop force-pushed the treasury-self-creation branch from 5120da3 to 571d903 Compare October 31, 2024 19:50
@rubycop rubycop changed the title Treasury self creation flow WIP: Treasury self creation flow Oct 31, 2024
@rubycop rubycop linked an issue Oct 31, 2024 that may be closed by this pull request
35 tasks
@rubycop rubycop force-pushed the treasury-self-creation branch from 6340508 to 9a5a128 Compare November 1, 2024 09:50
@rubycop rubycop force-pushed the treasury-self-creation branch from c8fa540 to 0bb18f3 Compare November 1, 2024 13:23
@rubycop rubycop changed the title WIP: Treasury self creation flow Treasury self creation flow Nov 12, 2024
Copy link
Collaborator

@Megha-Dev-19 Megha-Dev-19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments

@rubycop rubycop requested a review from Megha-Dev-19 November 16, 2024 12:14
@rubycop
Copy link
Collaborator Author

rubycop commented Nov 16, 2024

@race-of-sloths include

@race-of-sloths
Copy link

race-of-sloths commented Nov 16, 2024

@rubycop Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Do you want to apply for monthly streak? Get 8+ score for a single PR this month and receive boost for race-of-sloths!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@Megha-Dev-19 13

Your contribution is much appreciated with a final score of 13!
You have received 140 (130 base + 10 monthly bonus) Sloth points for this contribution

@Megha-Dev-19 received 25 Sloth Points for reviewing and scoring this pull request.

Congratulations @rubycop! Your PR was highly scored and you completed another monthly streak! To keep your monthly streak make another pull request next month and get 8+ score for it

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

Copy link
Collaborator

@Megha-Dev-19 Megha-Dev-19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

instances/treasury-factory.near/aliases.mainnet.json Outdated Show resolved Hide resolved
@Megha-Dev-19
Copy link
Collaborator

@race-of-sloths score 13

@rubycop
Copy link
Collaborator Author

rubycop commented Nov 18, 2024

Screenshot 2024-11-18 at 13 41 56 Screenshot 2024-11-18 at 13 42 07 Screenshot 2024-11-18 at 13 42 17 Screenshot 2024-11-18 at 13 42 33 Screenshot 2024-11-18 at 13 42 39 Screenshot 2024-11-18 at 13 42 57 Screenshot 2024-11-18 at 13 43 04 Screenshot 2024-11-18 at 13 43 11

@rubycop rubycop merged commit 8aa0b43 into main Nov 18, 2024
17 checks passed
@rubycop rubycop deleted the treasury-self-creation branch November 18, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Self Create Flow Front-End
3 participants