Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Payments] Show deleted proposals in history (Index deleted proposals) #182

Open
3 tasks
Tguntenaar opened this issue Dec 20, 2024 · 0 comments
Open
3 tasks

Comments

@Tguntenaar
Copy link
Collaborator

Tguntenaar commented Dec 20, 2024

Note – this might have a dependency on #157.

Background

Currently, when a user with create permission deletes a pending request they created, they are unable to see that request in the history table. This is because we index the DAO proposals the same way as the 'other' proposals and rfps. We get the contract state on the blockheight of the receipt from the RPC for every transaction. A problem presented itself when indexing the sputnik contract in this way. When an DAO member votes to remove the proposal it gets deleted from contract and the RPC returns an contract panic ERROR_NO_PROPOSAL.

User Story

As a user I would like to view which proposals were deleted in the history table.

Acceptance Criteria

  • When a user with create permission deletes a pending request, they should see a successful confirmation screen upon deletion with a link to the record
  • Clicking on the link to the record will take the user to the history table and highlight the deleted request
  • The successful delete request record should appear in the history table with a "Delete" status

Attachment

Screenshare.-.2025-01-22.11_56_36.AM.mp4

Technical Info

The number of indexed proposals should be the same as the number that gets returned by the get_last_proposal_id. Ensuring that even the deleted proposals are indexed.

@Tguntenaar Tguntenaar moved this from 🆕 Triage to 📋 Backlog in 🚀 DevHub Products Dec 20, 2024
@ori-near ori-near changed the title Index deleted DAO proposals [Payments] Show deleted proposals in history (Index deleted proposals) Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant