Restore Reach-based Lakes from v5.1.x #776
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scrasmussen
requested changes
Oct 23, 2024
scrasmussen
previously approved these changes
Oct 23, 2024
Co-authored-by: Ryan Cabell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: reach, lakes, routing
SOURCE: NCAR
DESCRIPTION OF CHANGES: support for lakes (reservoirs) in non-UDMP reach-based routing was added in version 5.1.1 but subsequently dropped from subsequent releases. This PR adds that functionality back in.
TESTS CONDUCTED: testing offline, will update in comments if necessary