Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NUOPC cap for GNU compilers #550

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danrosen25
Copy link
Collaborator

@danrosen25 danrosen25 commented Apr 28, 2021

TYPE: fix

KEYWORDS: NUOPC, GNU

SOURCE: Daniel Rosen ([email protected]) - NCAR/ESMF

DESCRIPTION OF CHANGES: Fix GNU compiling issues

ISSUE: none

TESTS CONDUCTED: Built and run on Cheyenne using gnu/9.1.0 and mpt/2.25. Note that HDF4-4.2.11 (outdated) was having issues building with gnu/10.1.0, which is the default on Cheyenne.

@rcabell rcabell marked this pull request as ready for review July 8, 2021 15:57
@rcabell rcabell marked this pull request as draft July 8, 2021 15:57
@rcabell rcabell marked this pull request as ready for review July 14, 2021 19:15
@rcabell rcabell marked this pull request as draft July 14, 2021 19:16
@rcabell rcabell mentioned this pull request Feb 1, 2022
6 tasks
@danrosen25 danrosen25 changed the base branch from v5.2.x to master March 24, 2022 23:49
@danrosen25 danrosen25 marked this pull request as ready for review March 25, 2022 14:16
@danrosen25 danrosen25 marked this pull request as draft March 25, 2022 19:16
@danrosen25
Copy link
Collaborator Author

This PR is on hold. I'm seeing bad values in the results using GNU 9.1.0. I've also had some trouble with variable initialization that may be due to compiler optimization. I may try to run with reduced optimization or switch the compiler when I have more time.

@scrasmussen
Copy link
Member

This PR is on hold. I'm seeing bad values in the results using GNU 9.1.0. I've also had some trouble with variable initialization that may be due to compiler optimization. I may try to run with reduced optimization or switch the compiler when I have more time.

Hi @danrosen25, had a PR meeting and was just wondering if the status of this PR had changed at all? Is there a test case on Cheyenne that you could point us to?

I had tested this PR, but not with NUOCP coupling... which kinda seems like the import part ; )

@danrosen25
Copy link
Collaborator Author

Hi @scrasmussen, this is still on hold I haven't been able to go through the debugging process to determine why the different compiler is producing different results. I'll have to run each component individually using Intel and GCC and see which component is different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants