Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XY_7_2 plot #28

Merged
merged 9 commits into from
Jan 24, 2020
Merged

Add XY_7_2 plot #28

merged 9 commits into from
Jan 24, 2020

Conversation

andersy005
Copy link
Contributor

@andersy005 andersy005 commented Jan 23, 2020

Towards #3

  • Original NCL:

  • Python Version:

sphx_glr_xy_7_2_lg_001

@erogluorhan
Copy link
Collaborator

Comparison of plots:

  1. Python version should divide x-axis into 5 minor-ticks instead of 3 between adjacent major ticks (e.g. 1970.0 and 1970.5

  2. Python plot is missing the very last curve change (which is the closest point to 1973.0) on the red dashed line plot that is apparent in NCL plot.

  3. If identical dash-spaces with NCL plot is of interest, the following code:
    ax2.plot(ds.time, ds.P, color=color, linestyle=linestyle, linewidth=2.0)
    can be exchanged with the following one:
    ax2.plot(ds.time, ds.P, color=color, linestyle=linestyle, dashes=[6.5, 3.7], linewidth=2.0)


fontsize = 24
labelsize = 20
color = "blue"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although explicit initialization of variables such as fontsize and labelsize contribute to the readability of the code since they are used as is in both plots, how about using variables such as color and linestyle with immediate values within plot codes instead of explicitly initializing them (because they have changing values for each plot)?

@andersy005
Copy link
Contributor Author

sphx_glr_xy_7_2_lg_001 (1)

@clyne clyne merged commit f8301dc into NCAR:master Jan 24, 2020
@andersy005 andersy005 deleted the scatter-4 branch January 24, 2020 22:23
@khallock khallock mentioned this pull request Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants