Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create contributors.md to recognize efforts of all contributors #125

Merged
merged 7 commits into from
Sep 5, 2024

Conversation

TeaganKing
Copy link
Collaborator

@TeaganKing TeaganKing commented Aug 21, 2024

This is an alphabetized list of contributors to CUPiD. I'm open to other suggestions on order, organization, etc. Please note if you are expecting to see anyone else on this list; it will be shared with the team before being published.

  • GitHub handles should be added

@TeaganKing TeaganKing self-assigned this Aug 22, 2024
@TeaganKing TeaganKing added the documentation Improvements or additions to documentation label Aug 22, 2024
@TeaganKing
Copy link
Collaborator Author

Please update/add names as applicable! I'm going to send this PR out in our biweekly announcements as well in case anyone else wants to opt in.

I also added a note in our wiki contributors guide to help encourage people to add their names here when they contribute.

@TeaganKing TeaganKing marked this pull request as ready for review August 29, 2024 14:23
@mnlevy1981
Copy link
Collaborator

This list looks great! I have two questions before approving:

  1. Should we update docs/conf.py to include this list on https://ncar.github.io/CUPiD/?
  2. How should we handle contributors whose affiliation changes? The two that names that jump out as having recently left NCAR are @rmshkv and @ALDepp

@TeaganKing
Copy link
Collaborator Author

TeaganKing commented Sep 4, 2024

Thanks @mnlevy1981 , good points!

To do before merging:

  • test github.io pages
  • update Anna's affiliation

@TeaganKing
Copy link
Collaborator Author

Screen Shot 2024-09-05 at 8 42 48 AM

The github.io page is rendering as expected! I'm going to commit one more minor change and then this should be ready for a final review, @mnlevy1981

Copy link
Collaborator

@mnlevy1981 mnlevy1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @TeaganKing!

@mnlevy1981 mnlevy1981 merged commit 2bb78a5 into NCAR:main Sep 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants