Some clean-up for key_metrics

[mnlevy1981]

1. Standardize the way dates are passed (glacier notebook pulls year out of full date string to match atmosphere)
2. Add option for baseline comparison to atmosphere NMSE
3. Update config.yml to use run 104 (keeping 092 as baseline)
4. Clean up time series generation (allow empty list to specify "don't convert any files to time series for this component")

All Submissions:

• Have you followed the guidelines in our Contributer's Guide](https://github.com/NCAR/CUPiD/wiki/Contributor's-Guide) (including the pre-commit check)?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

1. Does your submission pass tests?
2. Have you lint your code locally prior to submission?

Changes to Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?

[mnlevy1981]

There's not much change in the NMSE of surface pressure between 92 and 104:

The surface mass balance is very different, likely due to (a) only averaging over 20 years instead of 40, and (b) only using 25 years for the spin-up instead of 60:

The x-axis of this plot could be extended -- there's 40 years of data from 092 but only the last 20 years are shown

[mnlevy1981]

I'm also tempted to update the notebooks to hide input cells (as noted in #60 (comment))

[mnlevy1981]

Still to-do:

• Resolve max_years_per_timeseries_file discussion
• Update 104 to include 100 years of output, for more apples-to-apples comparison

[mnlevy1981]

Updated figures comparing 100 years of each run:

NMSE

SMB

I really like how the 104 vs 92 SMB plot has a sign change just above the southern tip of the island, that seems pretty interesting. Anyway, this is ready for final review / merging :)

[mnlevy1981]

It's interesting that the black line in

doesn't extend as far as the red and blue lines... going to try to fix that real quick

[mnlevy1981]

It's interesting that the black line in

doesn't extend as far as the red and blue lines... going to try to fix that real quick

fixed in c0ab02a

[TeaganKing]

@mnlevy1981 is this ready for review?

[mnlevy1981]

Yup, I think this is ready to go. Latest output is in #122 (comment) (except for the time series plot, which is updated in #122 (comment))

[TeaganKing]

Thanks for doing all of this clean up! The method for passing dates is looking much clearer, and the capability of adding an empty list is helpful. The plot is looking a lot better, too! I'm going to test this out locally as well.

[TeaganKing]

Looks good to me! Local testing worked smoothly. All tasks are completed despite the tasklist checker failing... I think this is because the last checkbox was checked off after the last commit was made.