Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new empty file #114

Closed
wants to merge 1 commit into from
Closed

Conversation

mnlevy1981
Copy link
Collaborator

@mnlevy1981 mnlevy1981 commented Jul 10, 2024

Trying to test an update to the PR Tasks Completed Check action

All Submissions:

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Trying to test an update to the PR Tasks Completed Check action
@mnlevy1981
Copy link
Collaborator Author

I'm still seeing

GITHUB_TOKEN Permissions
  Checks: read
  Metadata: read

which doesn't seem right, given tasklist_completed.yml contains

    permissions:
      checks: write

I'll keep digging in, but we may want to consider the other tasklist checker action instead?

@mnlevy1981
Copy link
Collaborator Author

mnlevy1981 commented Jul 10, 2024

(for the record, I updated the permissions based on kentaro-m/task-completed-checker-action#62 (comment) )

@TeaganKing TeaganKing added common utility enhancement New feature or request labels Jul 23, 2024
@TeaganKing
Copy link
Collaborator

TeaganKing commented Aug 20, 2024

Is it okay to close this PR, or did you want to do more testing with it @mnlevy1981 ?

I'm still waiting on hearing back from Joel about implementing the task list checker app within the NCAR org.

@mnlevy1981
Copy link
Collaborator Author

Let's close this and revisit it later when we have a better idea of how to get a task list checker to work :)

@mnlevy1981 mnlevy1981 closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common utility enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants