Deprecations #182
Deprecations #182
Conversation
| @@ -721,9 +721,8 @@ protected Object createLineRenderable(Iterable<? extends Position> positions, St | |||
| { | |||
| Path path = new Path(positions); | |||
| path.setPathType(pathType); | |||
| path.setFollowTerrain(true); | |||
| path.setSurfacePath(true); | |||
There was a problem hiding this comment.
What's the reasoning behind this change? Isn't the setAltitudeMode usage more illustrative of the different modes that a Path may use?
There was a problem hiding this comment.
I see that this pattern is changed in other classes as well, for instance the classes in the milstd2525 folder.
There was a problem hiding this comment.
Polyline (deprecated) and Path (which replaces it) have different treatments of followTerrain. The Path class was designed several years ago and I didn't want to modify its behavior.
I initially replaced polyline.setFollowTerrain with path.setFollowTerrain, but noticed that the behavior was different. Polyline implicitly also applies clamp_to_ground behaviour with followTerrain while path does not.
So rather than replace setFollowTerrain with two calls to achieve the same behavior, I expanded on the isSurfacePath pattern in the Path class to set followTerrain and clamp_to_ground in one call.
| path.setPathType(AVKey.GREAT_CIRCLE); | ||
| path.setAltitudeMode(WorldWind.CLAMP_TO_GROUND); |
There was a problem hiding this comment.
the setAltitudeMode function is also used in our other platforms (for instance, in Web WorldWind). Are we sure we want to get rid of this?
There was a problem hiding this comment.
The call to setSurfacePath on line 499 turns on clamp to ground. setAltitudeMode is still available on the Path class. That being said, please create an issue in WWW to make sure the designs of WWW and WWJ are aligned with respect to Paths and Symbology.
There was a problem hiding this comment.
|
The following examples and apps have been reviewed, covering a little more than two thirds of the files changed in this PR. Examples:
Apps:
No issues found in these. Couldn't find an example or app to test the following class, maybe we should consider making one:
|
|
@Beak-man With respect to the HTTPFileUpload class comment, it has been deprecated as of the 2.2 release and I intend to delete it in the release following 2.2. It's not something WWJ needs to provide. |
There was a problem hiding this comment.
Every related example was tested, as well as the apps (if superficially so, as is the case with the Search And Rescue app as explained above).
The issues encountered and documented in #183, #184, and #185 are not specific to this PR (they also happen in the develop branch) and appear to be related to their particular examples instead of being issues with the library itself.
Description of the Change
Code cleanup, fixes numerous lint issues and deprecations.
Why Should This Be In Core?
Improves code readability and removes reliance on outdated code.