Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create banner component #77

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Conversation

anilnatha
Copy link
Collaborator

@anilnatha anilnatha commented Oct 31, 2024

🗒️ Summary

This PR addresses the need to create a banner component for the portal website based on the designs we have in Figma. The dismiss capability was not added at this time.

⚙️ Test Data and/or Report

Tested locally and ensured that no build errors are generated when npm run build-lib is executed.

♻️ Related Issues

Fixes #78
refs NASA-PDS/portal-wp#90

…onal link/button element. Banner can be styled in one of two ways, an info variant (blue) or alert variant (red). Responsive behaviors are also implemented.
@eddiesarevalo eddiesarevalo self-requested a review October 31, 2024 21:53
Copy link
Member

@eddiesarevalo eddiesarevalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified banner by testing in portal-wp. Build is good. Approved!

@anilnatha anilnatha merged commit 29bc9d6 into develop Nov 4, 2024
3 checks passed
@anilnatha anilnatha deleted the features/create-banner-component branch November 4, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Banner Component
2 participants