Fix code scanning alert no. 24: Jinja2 templating with autoescape=False #341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/NASA-PDS/registry/security/code-scanning/24
To fix the problem, we need to ensure that the Jinja2
Environment
object is created withautoescape
enabled. This can be done by using theselect_autoescape
function, which will automatically enable autoescaping for specific file extensions like HTML and XML. This change will prevent XSS attacks by escaping any untrusted input rendered in the templates.We need to modify the creation of the
Environment
object in thecreate_product_external
andcreate_product_browse
functions to includeautoescape=select_autoescape(['html', 'xml'])
.Suggested fixes powered by Copilot Autofix. Review carefully before merging.