ensure repairkit compatibility with large-doc nodes #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdunnjpl
requested review from
tloubrieu-jpl,
nutjob4life and
collinss-jpl
as code owners
nutjob4life
reviewed
Sep 19, 2023
nutjob4life
approved these changes
Sep 19, 2023
This was referenced Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Repairkit hammers OpenSearch with queries requesting many (10k doc) docs, and doc updates. For nodes with large documents, this can cause errors both on the query side (450MB responses are not viable and cause overflows) and the update side (triggering indexing on 4.5GB of docs every couple of minutes also appears to be non-viable).
This PR implements repairkit-specific constraints to reduce page size, and limit the update throughput.
Logging is also improved significantly.
Of note, repairkit will now log an error at @jordanpadams request if it has to actually do anything, as this represents a failure of node-users to use an up-to-date version of harvest.
⚙️ Test Data and/or Report
Unit tests pass. Tested live against ATM-PROD and GEO-PROD
♻️ Related Issues
fixes #61