Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronization of Legacy Solr Registry in the new #68
Synchronization of Legacy Solr Registry in the new #68
Changes from 3 commits
1c38b1d
80b9031
2be77da
2143bf7
d80fbfe
15ae407
1f01794
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
request refactor - rather than defining sweepers and optional sweepers, then maintaining separate execution paths for each, it is preferable to
if that's not clear, let me know and I'll modify it first-thing Tuesday when I'm back at work - it's a quick change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
request: use descriptive variable names in preference to
o
,s
request: use a more idiomatic approach to the optional conditional check
if sweeper_name in args and arg[sweeper_name] == True
(I forget the syntax for pulling variable-named args from argparser, but you get the idea)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Alex, indeed I only tested with the option present.