refactor utils module #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdunnjpl
requested review from
tloubrieu-jpl,
nutjob4life and
collinss-jpl
as code owners
alexdunnjpl
force-pushed
the
post-repairkit-repair-kit-refactor
branch
from
6de4713
to
48a0468
Compare
nutjob4life
reviewed
Aug 31, 2023
|
|
||
|
|
||
| def get_human_readable_elapsed_since(begin: datetime) -> str: | ||
| elapsed_seconds = (datetime.now() - begin).total_seconds() |
There was a problem hiding this comment.
There's a humanize package that does stuff like this too—but this is pretty concise, which is nice. Just what you need!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Refactors the utils module for ease of maintenance
⚙️ Test Data and/or Report
Unit tests pass, manually tested all sweepers.
♻️ Related Issues
not related to any issue