Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix http retries, increase retries #57

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Conversation

alexdunnjpl
Copy link
Contributor

🗒️ Summary

Turns out requests throws requests.exceptions.HTTPError, not urllib.error.HTTPError. Who'd have ever known?

⚙️ Test Data and/or Report

Unit tests pass, no manual test

♻️ Related Issues

fixes #56

@sonatype-lift
Copy link

sonatype-lift bot commented Aug 3, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

Copy link
Contributor

@sjoshi-jpl sjoshi-jpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@alexdunnjpl alexdunnjpl merged commit 579f603 into main Aug 3, 2023
1 check passed
@alexdunnjpl alexdunnjpl deleted the 56-bugfix-http-retries branch August 3, 2023 18:17
Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tempts me to paraphrase a classic line from The Right Stuff (1983), as "requests's HTTPError is better than urllib's HTTPError."

@alexdunnjpl
Copy link
Contributor Author

And manually importing stuff rather than half-wittedly tapping out Alt+Enter is better than both sigh

@tloubrieu-jpl tloubrieu-jpl changed the title 56 bugfix http retries, increase retries Bugfix http retries, increase retries Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remedy absent retry-behaviour
3 participants