Publish stable Docker image corresponding to release/X.Y.Z tag #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nutjob4life
requested review from
tloubrieu-jpl,
alexdunnjpl and
collinss-jpl
as code owners
jordanpadams
requested changes
Mar 22, 2024
.github/workflows/stable-cicd.yaml
Outdated
| @@ -82,8 +79,20 @@ jobs: | |||
| pypi_username: ${{secrets.PYPI_USERNAME}} | |||
| pypi_password: ${{secrets.PYPI_PASSWORD}} | |||
| ADMIN_GITHUB_TOKEN: ${{secrets.ADMIN_GITHUB_TOKEN}} | |||
| # At this point, the Roundup as published release/X.Y.Z to GitHub and PyPI and advanced | |||
There was a problem hiding this comment.
@nutjob4life Is there any way we can grab the tag name release/X.Y.Z here, and use that to determine what version this should be? My only concern here is we are assuming this is a minor version increment, but what if it was a major or hotfix?
There was a problem hiding this comment.
Looks like we can: https://github.com/orgs/community/discussions/26686
There was a problem hiding this comment.
Ah sure, good point @jordanpadams. I pushed a new commit, 6e7631b, which simplifies and streamlines.
jordanpadams
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Merge this to take care of an issue in publishing mismatched versions of Docker images to the Docker Hub. Now when pushing
release/1.2.3to GitHub, you get Docker image tagged with:1.2.3in the Docker Hub.⚙️ Test Data and/or Report
See the corresponding entries for
registry-moppers, the "sandbox" version of this project, namely:release/3.0.0registry-moppers, which has a corresponding:3.0.0tag around the same timeframe.♻️ Related Issues