Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validate misbehavior in cucumber tests #835

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Fix validate misbehavior in cucumber tests #835

merged 3 commits into from
Nov 7, 2024

Conversation

al-niessner
Copy link

🗒️ Summary

Check for internal errors and use latest validate

⚙️ Test Data and/or Report

See automated unit testing below or run cucumber tests if not automated yet.

♻️ Related Issues

Closes #822

@al-niessner
Copy link
Author

@jordanpadams waiting for review on NASA-PDS/validate#1057 to see if it fixes this problem. Using validate project for this instead of maven artifact in eclipse makes a giant mess as it tries to run both cucumbers simultaneously then complains about it. So I need the latest validate artifact.

@al-niessner al-niessner marked this pull request as ready for review November 7, 2024 18:59
@al-niessner
Copy link
Author

@jordanpadams @nutjob4life @tloubrieu-jpl

All tests work now. I had to re-enable one of the tests validate.feature tests, but they all work independently as they do together. The schema(tron) mole (le Carre style) was the culprit here too.

@al-niessner
Copy link
Author

Is this a weird problem where the github actions is not pulling the very latest snapshot because it thinks it already has it?

@nutjob4life
Copy link
Member

@al-niessner yes it is; do you have a link to the GitHub Actions run?

@al-niessner
Copy link
Author

@nutjob4life

I do not understand the question, so no. I can click on details and ask it to run all jobs again. I did that and it seems to have made them all pass. Or an angel did something for me that I will never ask about. Exactly why you teach people to fish not give them a fish.

@al-niessner al-niessner self-assigned this Nov 7, 2024
@nutjob4life
Copy link
Member

@al-niessner hey I'm happy not to look the gift horse in the mouth—whatever that means! Let's press on!

@jordanpadams jordanpadams changed the title Issue 822: validate misbehaving in cucumber tests Fix validate misbehavior in cucumber tests Nov 7, 2024
@jordanpadams jordanpadams merged commit c76596b into main Nov 7, 2024
3 checks passed
@jordanpadams jordanpadams deleted the issue_822 branch November 7, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail when there are multiple tests with multiple schemas/schematrons
3 participants