Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this pip-installable with the dev extra again (bonus: no more Dependency Confusion Vulnerabilities) #443

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

nutjob4life
Copy link
Member

🗒️ Summary

While looking at some Dependabot issues, I noticed that this package could not be installed with pip install --editable '.[dev]'. I also noticed a large number of Dependency Confusion Vulnerabilities.

Merge this to make it installable again with the [dev] extra and to close those vulnerabilities.

⚙️ Test Data and/or Report

BEFORE:

INFO: pip is looking at multiple versions of pds-doi-service[dev] to determine which version is compatible with other requirements. This could take a while.
ERROR: Ignored the following yanked versions: 0.1.0, 0.1.1, 0.1.2, 0.1.3
ERROR: Ignored the following versions that require a different python version: 0.5.0 Requires-Python >=3.10; 0.5.1 Requires-Python >=3.10; 0.5.2 Requires-Python >=3.10; 2.1.0 Requires-Python >=3.10; 2.1.0rc1 Requires-Python >=3.10; 2.1.1 Requires-Python >=3.10; 2.2.2.240909 Requires-Python >=3.10; 8.0.0 Requires-Python >=3.10; 8.0.0rc1 Requires-Python >=3.10; 8.0.1 Requires-Python >=3.10; 8.0.2 Requires-Python >=3.10
ERROR: Could not find a version that satisfies the requirement types-pkg-resources; extra == "dev" (from pds-doi-service[dev]) (from versions: none)
ERROR: No matching distribution found for types-pkg-resources; extra == "dev"

AFTER:

Successfully installed pds-doi-service-2.5.0

NOTE: The tests still fail. But at least it installs now.

♻️ Related Issues

N/A.

Copy link
Contributor

@alexdunnjpl alexdunnjpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@nutjob4life
Copy link
Member Author

@alexdunnjpl 🤣🤣🤣🤣🤣🤣🤣🤣🤣

@nutjob4life nutjob4life merged commit f715352 into main Sep 16, 2024
3 of 4 checks passed
@nutjob4life nutjob4life deleted the twofer branch September 16, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants