Update SM2A workers python version to 3.11 #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarouane-ABDELHAK
requested review from
anayeaye,
ividito,
botanical and
smohiudd
botanical
reviewed
Dec 13, 2024
| @@ -91,6 +91,7 @@ module "sma-base" { | |||
| VECTOR_SECRET_NAME = var.vector_secret_name | |||
| ASSUME_ROLE_READ_ARN = var.assume_role_read_arn | |||
| ASSUME_ROLE_WRITE_ARN = var.assume_role_write_arn | |||
| SM2A_BASE_URL = module.sma-base.airflow_url | |||
There was a problem hiding this comment.
Does the module have airflow_url? https://github.com/NASA-IMPACT/self-managed-apache-airflow/blob/main/infrastructure/varaibles.tf
I can't find it. I think the file I linked above should also be renamed to variables.tf (just a small typo).
There was a problem hiding this comment.
It does have it as an output: https://github.com/NASA-IMPACT/self-managed-apache-airflow/blob/main/infrastructure/outputs.tf#L5
We are using the same output to show SM2A URL when we deploy https://github.com/NASA-IMPACT/veda-data-airflow/blob/dev/sm2a/infrastructure/outputs.tf#L1
Filename typo fixed. Thank you
botanical
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Summary of changes
fixing the issue #270
Changes