Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: coalesce empty string to false #116

Merged
merged 1 commit into from
Mar 6, 2024
Merged

fix: coalesce empty string to false #116

merged 1 commit into from
Mar 6, 2024

Conversation

ividito
Copy link
Contributor

@ividito ividito commented Mar 5, 2024

Fixes deployment failures if CLOUDFRONT_ID is using default value (empty string).

@smohiudd
Copy link
Contributor

smohiudd commented Mar 5, 2024

@ividito to confirm, this is for the conditional for if the cloudfront behaviour should be updated? So right now we're not going to worry about cloudfront and just use the apigateway url?

Copy link
Member

@botanical botanical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks technically valid to me! I'm going to test it with my MCP deployment. But I'll let someone else give the final approval

@ividito ividito merged commit e2e89f4 into dev Mar 6, 2024
12 checks passed
@ividito ividito deleted the fix/coalesce-cf-id branch March 6, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants