Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove features API, add veda deploy action #115

Closed
wants to merge 15 commits into from
Closed

Remove features API, add veda deploy action #115

wants to merge 15 commits into from

Conversation

smohiudd
Copy link
Contributor

@smohiudd smohiudd commented Mar 5, 2024 •
edited
Loading

PR includes the following:

  • The current implementation of veda features API requires a separate VPC which will not work in MCP. There is a PR in veda-features-api which uses a shared VPC but has not been merged. Until veda-features-api uses a shared VPC, this PR comments out the features api in airflow so it can be deployed in MCP.
  • Includes deploy action that can be used by veda-deploy

@smohiudd smohiudd changed the title Feature/preproduction Remove features API, add veda deploy action Mar 5, 2024
@smohiudd smohiudd requested a review from anayeaye March 5, 2024 22:10
@smohiudd smohiudd marked this pull request as ready for review March 5, 2024 22:10
slesaad
slesaad reviewed Mar 5, 2024
View reviewed changes
.github/actions/terraform-deploy/action.yml
@@ -0,0 +1,62 @@
name: Deploy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already in #111 so can we not add it here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we can probably remove this one (it's also out of date).

@smohiudd smohiudd closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slesaad slesaad slesaad left review comments

@anayeaye anayeaye Awaiting requested review from anayeaye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smohiudd @slesaad