앱 설정 UI 작업 #38
Open
앱 설정 UI 작업 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- delegate 설정 함수 나눔
Minny27
approved these changes
Aug 12, 2024
| tableView | ||
| ]) | ||
|
|
||
| setConstraints() |
There was a problem hiding this comment.
제약 조건을 나누는 함수를 따로 빼는 게 나을 지 고민해봐야겠네요
| make.horizontalEdges.bottom.equalToSuperview() | ||
| } | ||
|
|
||
| setTableView() |
There was a problem hiding this comment.
delegate를 위임하는 함수와 data binding함수를 나누는 게 좋아보입니다.
| import RxSwift | ||
|
|
||
| class BaseSettingViewController: NagazaViewController { | ||
| private var tableViewData = PublishRelay<[String]>() |
There was a problem hiding this comment.
BaseSettingViewController를 상속할 때 동일한 타입의 데이터면 괜찮을 수 있는데
각 화면마다 데이터 타입이 달라질 수 있어서 데이터는 각 vc의 view model에서 관리하는게 어떨까 싶습니다.
| @@ -13,7 +13,7 @@ public final class AppSettingBuilder: AppSettingBuildable { | |||
| public func build(rootViewControllable: ViewControllable) -> AppSettingCoordinating { | |||
|
|
|||
| let coordinator = AppSettingCoordinator(viewControllable: rootViewControllable) | |||
|
|
|||
| coordinator.start() | |||
There was a problem hiding this comment.
Coordinator는 전체적으로 잘 적용하신 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Key Changes 🔑