Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: scheduled&manual workflow to update bin.walrus.site #91

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

mlegner
Copy link
Collaborator

@mlegner mlegner commented Jul 19, 2024

@mlegner mlegner force-pushed the ml/ci-update-bin-walrus-site branch 2 times, most recently from b6aaafd to 9b45cac Compare July 19, 2024 10:53
@mlegner mlegner force-pushed the ml/ci-update-bin-walrus-site branch from 9b45cac to e4f3ba9 Compare July 19, 2024 10:59
@mlegner mlegner marked this pull request as ready for review July 19, 2024 10:59
@mlegner mlegner requested a review from giac-mysten July 19, 2024 11:01
Copy link
Contributor

@giac-mysten giac-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mlegner , looks great! One thing I noticed is that the root page for the site generated by the --list-directory command has the title "Directory listing for /". The "/" is not particularly descriptive, maybe we can use the name of the folder. Opened an issue on walrus sites

.github/actions/set-up-walrus/action.yaml Show resolved Hide resolved
.github/workflows/update-binaries.yaml Show resolved Hide resolved
@mlegner mlegner merged commit 27b294a into main Jul 19, 2024
6 checks passed
@mlegner mlegner deleted the ml/ci-update-bin-walrus-site branch July 19, 2024 12:38
@quepcompute
Copy link
Contributor

It's a bit unfortunate that we need a personal access token in the calling workflow
This is is common practice within the Mysten org right now. AFAIK they're being used where workflows touch multiple repositories.

@quepcompute
Copy link
Contributor

      - name: Copy site-builder binary
        run: "cp bin/site-builder site/site-builder-ubuntu-x86_64"

      - name: Update Walrus Site
        run: >
          RUST_LOG=site_builder=debug,walrus=debug,info
          site-builder
          --config walrus-sites/site-builder/assets/builder-example.yaml
          update --list-directory site ${{ vars.WALRUS_SITE_BIN_OBJECT }}

When the devnet workflow is being executed, the jobs for each arch are running in parallel, @mlegner can you confirm that only the ubuntu-x86_64 job needs to call out to this workflow?

@mlegner
Copy link
Collaborator Author

mlegner commented Jul 26, 2024

can you confirm that only the ubuntu-x86_64 job needs to call out to this workflow?

Ideally we would call this workflow when all three of the builds succeeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Walrus site containing the latest binaries and update it automatically
3 participants