Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add white bg to sites diagram #88

Merged
merged 1 commit into from
Jul 9, 2024
Merged

docs: add white bg to sites diagram #88

merged 1 commit into from
Jul 9, 2024

Conversation

mlegner
Copy link
Collaborator

@mlegner mlegner commented Jul 9, 2024

Before, this didn't work in dark mode:
image

Afterwards, this won't win a design price, but it's at least readable:
image

@mlegner mlegner requested a review from janetwu11 July 9, 2024 12:46
Copy link
Contributor

github-actions bot commented Jul 9, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-09 12:49 UTC

Copy link

@janetwu11 janetwu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the white background!

@mlegner mlegner merged commit 18ce3ef into main Jul 9, 2024
7 checks passed
@mlegner mlegner deleted the ml/sites-diagram-bg branch July 9, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants