Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs work #194

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Docs work #194

wants to merge 3 commits into from

Conversation

manolisliolios
Copy link
Collaborator

No description provided.

Copy link

changeset-bot bot commented Oct 30, 2024

⚠️ No Changeset found

Latest commit: 46beaf4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
suins-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 7:57pm

Copy link
Contributor

@stefan-mysten stefan-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a quick look over the text. I will spend some time to understand the flow and leave comments.

@@ -0,0 +1,19 @@
# Move Registry

Move Registry is built to provide a name service for interacting / building with packages from the ecosystem. You could consider it the name service for packages.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Move Registry is built to provide a name service for interacting / building with packages from the ecosystem. You could consider it the name service for packages.
Move Registry provides a name service for interacting and building with packages from the ecosystem.

documentation/pages/move-registry.mdx Outdated Show resolved Hide resolved

## Why would I use the Move Registry?

Move Registry provides a uniform (single source of truth) naming service for packages in the Move ecosystem.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this should be in introduction as well.

## Why would I use the Move Registry?

Move Registry provides a uniform (single source of truth) naming service for packages in the Move ecosystem.
This means that you can reference packages by their names, and the Move Registry will resolve the package address for you, despite the network*.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This means that you can reference packages by their names, and the Move Registry will resolve the package address for you, despite the network*.
It allows to reference packages by their names, and the Move Registry will resolve the package address, despite the network.

Comment on lines +15 to +16
Additionally, Move Registry helps with working with versioning of packages. You can call a specific version of a package easily, without having to
resolve the addresses yourself, or worry about the package being updated (name without a specified version defaults to the latest).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Additionally, Move Registry helps with working with versioning of packages. You can call a specific version of a package easily, without having to
resolve the addresses yourself, or worry about the package being updated (name without a specified version defaults to the latest).
Additionally, Move Registry helps with working with versioning of packages. Call a specific version of a package easily, without having to
resolve the addresses or worry about the package being updated. For example, name without a specified version defaults to the latest.

@@ -0,0 +1,10 @@
# Best Practises
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would really benefit from an example.


# Typescript SDK plugin

The purpose of the MVR TypeScript SDK plugin is to offer developers a seamless experience when building PTBs with MVR names.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about my noob question but what is an SDK plugin?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of the MVR TypeScript SDK plugin is to offer developers a seamless experience when building PTBs with MVR names.
This plugin resolves MVR names to their respective addresses before constructing the PTB, caching the results during each runtime.

This also applies to type names, which have traditionally been harder to refer to, especially across package upgrades.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This also applies to type names, which have traditionally been harder to refer to, especially across package upgrades.
This also applies to type names, especially across package upgrades.

Comment on lines +16 to +18
```bash
TODO: add installation command
```
Copy link
Contributor

@stefan-mysten stefan-mysten Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Download the correct binary file according to your OS and architecture from GitHub release page:
https://github.com/MystenLabs/mvr/releases/latest

After downloading the file, rename the binary to mvr and put it on your PATH. Below are examples on how to do it on three popular shells:

For Zsh

  1. Open the zshrc file
nano ~/.zshrc
  1. Add this line at the end, replacing /path/to/your/folder with the actual folder path to the binary:
 export PATH="/path/to/your/folder:$PATH"
  1. Save the file and source it to apply changes:
source ~/.zshrc

For bash

  1. Open your .bashrc file (or .bash_profile on macOS):
nano ~/.bashrc
  1. Add this line at the end, replacing /path/to/your/folder with the actual folder path to the binary:
 export PATH="/path/to/your/folder:$PATH"
  1. Save the file and source it to apply changes:
source ~/.bashrc

For fish

  1. Open your Fish configuration file:
nano ~/.config/fish/config.fish
  1. Add this line, replacing /path/to/your/folder with your desired path:
set -Ux fish_user_paths /path/to/your/folder $fish_user_paths
  1. Fish automatically loads this file, so you don’t need to manually source it.

Now you can call mvr --help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants