Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pricing Module and Cleanup (WIP) #189

Closed
wants to merge 8 commits into from
Closed

Pricing Module and Cleanup (WIP) #189

wants to merge 8 commits into from

Conversation

leecchh
Copy link
Contributor

@leecchh leecchh commented Oct 21, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 67b4df1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
suins-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 8:04pm

@leecchh leecchh changed the title Pricing Module and Cleanup Pricing Module and Cleanup (WIP) Oct 21, 2024
manolisliolios
manolisliolios reviewed Oct 22, 2024
View reviewed changes
packages/registration/sources/register.move Outdated

assert!(payment.value() == price, EIncorrectAmount);
assert!(coin::value(&payment) == price, EIncorrectAmount);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why move away from receiver syntax??

manolisliolios
manolisliolios reviewed Oct 22, 2024
View reviewed changes
packages/suins/sources/domain.move
/// Checks if `parent` domain is a valid parent for `child`.
public fun is_parent_of(parent: &Domain, child: &Domain): bool {
number_of_levels(parent) < number_of_levels(child) &&
number_of_levels(parent) < number_of_levels(child) &&
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
number_of_levels(parent) < number_of_levels(child) &&
parent.number_of_levels() < child.number_of_levels() &&

manolisliolios
manolisliolios reviewed Oct 22, 2024
View reviewed changes
packages/suins/sources/domain.move
/// Checks if `parent` domain is a valid parent for `child`.
public fun is_parent_of(parent: &Domain, child: &Domain): bool {
number_of_levels(parent) < number_of_levels(child) &&
number_of_levels(parent) < number_of_levels(child) &&
&parent(child).labels == &parent.labels
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
&parent(child).labels == &parent.labels
child.parent().labels == &parent.labels

manolisliolios
manolisliolios reviewed Oct 22, 2024
View reviewed changes
packages/renewal/sources/renew.move Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can re-deploy this package and deauthorize the old / authorize the new. We can avoid the V2 structs that way.

@leecchh leecchh changed the base branch from main to tlee/formatter October 22, 2024 20:19
@leecchh leecchh closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manolisliolios manolisliolios manolisliolios left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leecchh @manolisliolios