Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Don't error if we cannot connect to active env #21116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stefan-mysten
Copy link
Contributor

Description

If the CLI cannot get the client that should connect to the active environment set in the config, it will error. This creates troubles for when you work on a local network and then stop it. Every client (and a few other) command will now error.

This PR fixes this by relaxing a bit the condition.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI: Fixed the bug when the CLI cannot connect to the active environment leading to an error on most commands.
  • Rust SDK:

@stefan-mysten stefan-mysten requested a review from a team February 6, 2025 07:08
@stefan-mysten stefan-mysten self-assigned this Feb 6, 2025
Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2025 7:09am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2025 7:09am

@stefan-mysten stefan-mysten temporarily deployed to sui-typescript-aws-kms-test-env February 6, 2025 07:08 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant