Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mutex table for shared version assignment instead of optimistic transaction #21107

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

andll
Copy link
Contributor

@andll andll commented Feb 5, 2025

This should be equivalent both functionally and from performance point of view, but removes requirements from DB to support optimistic transactions, so we can consider migrating epoch db to tidehunter

Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 10:24pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 10:24pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 10:24pm

@andll andll temporarily deployed to sui-typescript-aws-kms-test-env February 5, 2025 21:53 — with GitHub Actions Inactive
@andll andll force-pushed the version_assignment_lock branch from 2f8774c to 406addd Compare February 5, 2025 22:17
@andll andll temporarily deployed to sui-typescript-aws-kms-test-env February 5, 2025 22:17 — with GitHub Actions Inactive
@andll andll force-pushed the version_assignment_lock branch from 406addd to 7110df9 Compare February 5, 2025 22:23
@andll andll temporarily deployed to sui-typescript-aws-kms-test-env February 5, 2025 22:23 — with GitHub Actions Inactive
@andll andll requested a review from mystenmark February 5, 2025 22:27
@andll andll marked this pull request as ready for review February 5, 2025 22:27
@andll andll temporarily deployed to sui-typescript-aws-kms-test-env February 5, 2025 22:27 — with GitHub Actions Inactive
@andll andll merged commit 3ee9343 into main Feb 5, 2025
75 of 82 checks passed
@andll andll deleted the version_assignment_lock branch February 5, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants