rpc benchmark: handle JSON RPC cursor breaking change #21099
+298
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
gegaowp
force-pushed
the
json-rpc-adapter
branch
from
18e6fe3 to
8636f5c
Compare
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
gegaowp
commented
Feb 5, 2025
| const WALLET_HOST_PREFIX: &str = "wallet"; | ||
|
|
||
| #[derive(Debug, Serialize, Deserialize)] | ||
| struct LogEntry { |
There was a problem hiding this comment.
this struct is technically duplicate with the one in pull_grafana_logs, leaving it here so that
- no extra dependencies for simplicity
- the dup is minimal and I do not expect many incremental changes looking forward so it not much of extra burden to carry
gegaowp
force-pushed
the
json-rpc-adapter
branch
from
8636f5c to
5ff536b
Compare
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
gegaowp
commented
Feb 5, 2025
| use tracing::{debug, info}; | ||
|
|
||
| const METHODS_TO_AGGREGATE: [&str; 3] = | ||
| ["suix_getOwnedObjects", "suix_getAllCoins", "suix_getCoins"]; |
There was a problem hiding this comment.
confirmed with @emmazzz that Balance is not affected, lemme know in case I missed other methods.
gegaowp
force-pushed
the
json-rpc-adapter
branch
from
5ff536b to
85f8a18
Compare
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
["suix_getOwnedObjects", "suix_getAllCoins", "suix_getCoins"]based on both method and params except cursor and limits.Test plan
local run of grafana_pull_logs and process_jsonl scripts locally, example output lines are like
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.