Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonrpc: unlimit the number of concurrent jsonrpc requests #21012

Conversation

bmwill
Copy link
Contributor

@bmwill bmwill commented Jan 30, 2025

The jsonrpsee library is artificially limiting the number of concurrent requests that the server can process to ~100 since its treating each request as a separate connection. In order to work around this we can just set the maximum number of connections for the jsonrpsee service to a high number since its not actually controlling the number of connections.

Description

Describe the changes or additions included in this PR.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

The jsonrpsee library is artificially limiting the number of concurrent
requests that the server can process to ~100 since its treating each
request as a separate connection. In order to work around this we can
just set the maximum number of connections for the jsonrpsee service to
a high number since its not actually controlling the number of
connections.
Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 3:45pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2025 3:45pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2025 3:45pm

@bmwill bmwill temporarily deployed to sui-typescript-aws-kms-test-env January 30, 2025 15:27 — with GitHub Actions Inactive
@bmwill bmwill requested review from johnjmartin and ebmifa January 30, 2025 15:27
@bmwill bmwill merged commit c1d24cc into MystenLabs:releases/sui-v1.41.0-release Jan 30, 2025
46 of 47 checks passed
@bmwill bmwill deleted the releases/sui-v1.41.0-release branch January 30, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants