[test-infra][2/n] Replace Move's .exp tests with cargo-insta #21004
+62,353
−48,213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
tnowacki
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tnowacki
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
approved these changes
Jan 31, 2025
Comment on lines
227
to
232
| _ if path_extension == MOVE_EXTENSION => None, | ||
| _ if path_extension == TEST_EXT => Some(TEST_EXT), | ||
| _ if path_extension == UNUSED_EXT => Some(UNUSED_EXT), | ||
| _ if path_extension == MIGRATION_EXT => Some(MIGRATION_EXT), | ||
| _ if path_extension == IDE_EXT => Some(IDE_EXT), | ||
| _ => panic!("Unknown extension: {}", path_extension.to_string_lossy()), |
There was a problem hiding this comment.
What about making this a match? Or is path_extension a path of some kinda and match doesn't like that? i.e., what about something like
let test_kind = match path_extension {
MOVE_EXTENSION = NONE,
x @ (TEST_EXT | UNUSED_EXT | MIGRATION_EXT | IDE_EXT) => Some(x),
_ => panic!(...),
};| @@ -52,177 +66,236 @@ fn default_testing_addresses(flavor: Flavor) -> BTreeMap<String, NumericalAddres | |||
| .collect() | |||
| } | |||
|
|
|||
| fn move_check_testsuite(path: &Path) -> datatest_stable::Result<()> { | |||
| // fn move_check_testsuite(path: &Path) -> datatest_stable::Result<()> { | |||
Comment on lines
+277
to
+282
| let p; | ||
| let test_name = { | ||
| p = path.with_extension(""); | ||
| assert!(p.extension().is_none()); | ||
| p.file_name().unwrap().to_string_lossy() | ||
| }; |
There was a problem hiding this comment.
I believe this is equivalent to
let test_name = path.file_stem().unwrap().to_string_lossy().as_ref();and that might be a bit cleaner?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test plan
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.