Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] create dry run helper for sui transactional test runner framework #20920

Conversation

jordanjennings-mysten
Copy link
Contributor

@jordanjennings-mysten jordanjennings-mysten commented Jan 18, 2025

Description

motivation: #20109

Mirroring the existing --dev-inspect flag, this change adds --dry-run for sui transactional test runner framework. Pulls out common code into tx_summary_from_effects.

Test plan

Added new tests for reference return types. Dev inspect flag allows reference return while dry run does not.


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@jordanjennings-mysten jordanjennings-mysten requested a review from a team January 18, 2025 00:12
Copy link

vercel bot commented Jan 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 1:24am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2025 1:24am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2025 1:24am

Copy link
Contributor

@tnowacki tnowacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests!

@jordanjennings-mysten jordanjennings-mysten temporarily deployed to sui-typescript-aws-kms-test-env January 30, 2025 01:23 — with GitHub Actions Inactive
@jordanjennings-mysten jordanjennings-mysten enabled auto-merge (squash) January 30, 2025 01:25
@jordanjennings-mysten jordanjennings-mysten merged commit 8ba733e into MystenLabs:main Jan 30, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants