-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] create dry run helper for sui transactional test runner framework #20920
Merged
jordanjennings-mysten
merged 5 commits into
MystenLabs:main
from
jordanjennings-mysten:dry-run-helper-sui-adapter-tx-tests
Jan 30, 2025
Merged
[tests] create dry run helper for sui transactional test runner framework #20920
jordanjennings-mysten
merged 5 commits into
MystenLabs:main
from
jordanjennings-mysten:dry-run-helper-sui-adapter-tx-tests
Jan 30, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 18, 2025 00:12 — with
GitHub Actions
Inactive
jordanjennings-mysten
force-pushed
the
dry-run-helper-sui-adapter-tx-tests
branch
from
January 27, 2025 22:36
bb97d62
to
756dfd7
Compare
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 27, 2025 22:36 — with
GitHub Actions
Inactive
jordanjennings-mysten
force-pushed
the
dry-run-helper-sui-adapter-tx-tests
branch
from
January 27, 2025 23:03
756dfd7
to
aab249c
Compare
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 27, 2025 23:03 — with
GitHub Actions
Inactive
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 28, 2025 01:59 — with
GitHub Actions
Inactive
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 28, 2025 20:48 — with
GitHub Actions
Inactive
jordanjennings-mysten
force-pushed
the
dry-run-helper-sui-adapter-tx-tests
branch
from
January 28, 2025 20:51
3291c71
to
4600ddc
Compare
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 28, 2025 20:51 — with
GitHub Actions
Inactive
tnowacki
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tests!
crates/sui-adapter-transactional-tests/tests/dev_inspect/reference_return_value.move
Outdated
Show resolved
Hide resolved
crates/sui-adapter-transactional-tests/tests/dry_run/reference_return_value.move
Outdated
Show resolved
Hide resolved
jordanjennings-mysten
force-pushed
the
dry-run-helper-sui-adapter-tx-tests
branch
from
January 29, 2025 23:13
4600ddc
to
3d1adab
Compare
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 29, 2025 23:13 — with
GitHub Actions
Inactive
jordanjennings-mysten
force-pushed
the
dry-run-helper-sui-adapter-tx-tests
branch
from
January 29, 2025 23:34
3d1adab
to
2840e64
Compare
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 29, 2025 23:34 — with
GitHub Actions
Inactive
jordanjennings-mysten
force-pushed
the
dry-run-helper-sui-adapter-tx-tests
branch
from
January 29, 2025 23:57
2840e64
to
f607450
Compare
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 29, 2025 23:57 — with
GitHub Actions
Inactive
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 30, 2025 01:23 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
motivation: #20109
Mirroring the existing
--dev-inspect
flag, this change adds--dry-run
for sui transactional test runner framework. Pulls out common code intotx_summary_from_effects
.Test plan
Added new tests for reference return types. Dev inspect flag allows reference return while dry run does not.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.