Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Manipulation ENV #265

Merged
merged 5 commits into from
Oct 31, 2024
Merged

BUGFIX: Manipulation ENV #265

merged 5 commits into from
Oct 31, 2024

Conversation

cherylwang20
Copy link
Collaborator

No description provided.

Balint-H
Balint-H approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@Balint-H Balint-H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and I think the double <= is appropriate for the index ranges based on their definition.

Vittorio-Caggiano
Vittorio-Caggiano approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@Vittorio-Caggiano Vittorio-Caggiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Vittorio-Caggiano Vittorio-Caggiano merged commit 7927eb0 into main Oct 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Balint-H Balint-H Balint-H approved these changes

@Vittorio-Caggiano Vittorio-Caggiano Vittorio-Caggiano approved these changes

@raku-slyu raku-slyu Awaiting requested review from raku-slyu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cherylwang20 @Vittorio-Caggiano @Balint-H