Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MC24 eval phase #223

Merged
merged 54 commits into from
Sep 16, 2024
Merged

MC24 eval phase #223

merged 54 commits into from
Sep 16, 2024

Conversation

Vittorio-Caggiano
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@cherylwang20 cherylwang20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


def __getattr__(self, name):
if name == 'integers':
def integers(*args, **kwargs):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we know the version of numpy that has this issue, we might consider adding a implemented for condition like we do for gym

@implement_for("numpy", None, "0.13")
def np_random_integers():
    return self.np_random.integers(*args, **kwargs)

@implement_for("numpy", "0.13", None)
def np_random_integers():
    return self.np_random.randint(*args, **kwargs)

.....

@Vittorio-Caggiano Vittorio-Caggiano merged commit cb40b44 into dev Sep 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants