Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MyoChallenge Manipulation Track Metric #213

Merged
merged 5 commits into from
Aug 27, 2024

Conversation

cherylwang20
Copy link
Collaborator

@cherylwang20 cherylwang20 commented Aug 26, 2024

  • updated the evaluation metric for evalai.

@cherylwang20 cherylwang20 changed the title MyoChallenge Manipulation Track Phase 2 MyoChallenge Manipulation Track Metric Aug 26, 2024
Copy link
Collaborator

@Vittorio-Caggiano Vittorio-Caggiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -236,7 +237,8 @@ def get_reward_dict(self, obs_dict):
("pass_err", pass_dist + np.log(pass_dist + 1e-3)),
# Must keys
("sparse", 0),
("solved", self.check_solve(goal_dis)),
("goal_dist", goal_dis),
("solved", goal_dis < 0.05),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have this as a variable?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in this commit: 3281da5

Copy link
Collaborator

@Vittorio-Caggiano Vittorio-Caggiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Vittorio-Caggiano Vittorio-Caggiano merged commit 76f3925 into MyoHub:dev Aug 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants