minor fixes to documentation and editable installation #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikashplus
reviewed
Oct 22, 2023
| @@ -38,7 +38,7 @@ It is possible to install MyoSuite with: | |||
| ``` bash | |||
| pip install -U myosuite | |||
| ``` | |||
| for advanced installation, see [here](setup/README.md). | |||
| for advanced installation, see [here](https://myosuite.readthedocs.io/en/latest/install.html#alternative-installing-from-source). | |||
There was a problem hiding this comment.
from here -- https://myosuite.readthedocs.io/en/latest/install.html#alternative-installing-from-source
pip install -e -r requirements==>pip install -e .- Remove the options
export PYTHONPATH="<path/to/myosuite>:$PYTHONPATH". This pollutes the whole path for all the envs and is a recipe for complications.
There was a problem hiding this comment.
changed here
There was a problem hiding this comment.
@Vittorio-Caggiano -- what about this?
docs/source/publications.rst
Outdated
|
|
||
| * Vittorio Caggiano, Sudeep Dasari, Vikash Kumar, `MyoDex: A Generalizable Prior for Dexterous Manipulation`, *International Conference on Machine Learning (ICML)*, 2023 | ||
| * Vittorio Caggiano, Sudeep Dasari, Vikash Kumar, `MyoDex: A Generalizable Prior for Dexterous Manipulation <https://arxiv.org/abs/2309.03130>`_, *International Conference on Machine Learning (ICML)*, 2023 |
There was a problem hiding this comment.
Better to add the webpage link
There was a problem hiding this comment.
added web links
docs/source/publications.rst
Outdated
|
|
||
| * Cameron Berg, Vittorio Caggiano*, Vikash Kumar*, `SAR: Generalization of Physiological Dexterity via Synergistic Action Representation', *Robotics: Science and Systems (RSS)*, 2023 | ||
| * Cameron Berg, Vittorio Caggiano*, Vikash Kumar*, `SAR: Generalization of Physiological Dexterity via Synergistic Action Representation <https://arxiv.org/abs/2307.03716>`_, *Robotics: Science and Systems (RSS)*, 2023 |
There was a problem hiding this comment.
Better to add the webpage link
There was a problem hiding this comment.
added web links
vikashplus
reviewed
Oct 27, 2023
docs/source/install.rst
Outdated
| .. code-block:: bash | ||
|
|
||
| export PYTHONPATH="<path/to/myosuite>:$PYTHONPATH" | ||
| pip install -e -r . |
There was a problem hiding this comment.
double-check this. I believe -r option is when you are specifying a file for requirements.
There was a problem hiding this comment.
fixed in the last commit
Vittorio-Caggiano
added
the
documentation
vikashplus
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.