Merge for P2 #101
Merged
Merge for P2 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not implemented; task randomization not implemented; random reset not properly implemented;
… to fix initial agent position and TEST TEST TEST
…er sensors; chasing opponent
…angefinders and heightmap observation; TODO more patches
…ition and get_lose_condition separately for chase and evade tasks; changed fallen condition
| @@ -156,7 +156,7 @@ def chase_player(self): | |||
| new_vec = np.array([np.cos(theta), np.sin(theta)]) | |||
| new_vec2 = pel - vec | |||
| vel = np.dot(new_vec, new_vec2) | |||
| return np.array([1.0, vel]) | |||
| return np.array([self.rng.uniform(1, 5), vel]) | |||
There was a problem hiding this comment.
@elladyr is this wanted here?
There was a problem hiding this comment.
I think we need to set vel per reset, not sample it everytime in this function
There was a problem hiding this comment.
Let me correct that too.
There was a problem hiding this comment.
Sample chaser velocities corrected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge for Phase 2 environments