Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments related helper functions and types #15

Merged
merged 6 commits into from
Apr 27, 2024

Conversation

nain-F49FF806
Copy link
Contributor

@nain-F49FF806 nain-F49FF806 commented Apr 27, 2024

Greetings!

This PR adds helper functions that makes working with the comments trees easier

You can now also use --json option when reading paste to see comments!

Best regards.

use --json option when reading paste.
@nain-F49FF806 nain-F49FF806 marked this pull request as ready for review April 27, 2024 09:35
Copy link
Owner

@Mydayyy Mydayyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings,

Thank you for this great addition. I just got two minor notes/questions where I would appreciate your opinion!

Best Regards
Mydayyy

src/privatebin.rs Outdated Show resolved Hide resolved
src/privatebin.rs Outdated Show resolved Hide resolved
@nain-F49FF806
Copy link
Contributor Author

nain-F49FF806 commented Apr 27, 2024

Greetings!

Thanks for reviewing this.
I have some additional changes ready. Have split them into another PR for easier review. Please see https://github.com/nain-F49FF806/pbcli/pull/2/files
If you prefer, I can push them into this branch to review at one place.

Best regards.
:)

@Mydayyy
Copy link
Owner

Mydayyy commented Apr 27, 2024

I'll look over that in the new branch, since I believe it makes it a bit easier to follow.

@Mydayyy Mydayyy merged commit a4a88d8 into Mydayyy:master Apr 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants