This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Simple Play Video Implementation for Mycroft GUI #2913
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devops-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Succeeded (Results) |
|
Closing PR since we're archiving the repo |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simple standalone implementation of enabling video playback by skills inside Mycroft-GUI without Common Play Framework integration. This PR is being opened because the previous PR for play video #2683 is blocked on Common Play Service implementation.
Skills should be allowed to display videos embedded in GUI and not be opened in external applications as the GUI is fully capable of playing Videos via inbuilt Video QML type regardless of Common Play Service Implementation.
How to test
Sample Test Skill To Test PR:
testshowvideo.tar.gz
Contributor license agreement signed?
CLA [x] (Whether you have signed a CLA - Contributor Licensing Agreement