-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tx Receipt Type Changes #4238
base: master
Are you sure you want to change the base?
Tx Receipt Type Changes #4238
Conversation
Staging build: MyCryptoBuilds |
224d9ad
to
a1a86de
Compare
1551506
to
0a26eb5
Compare
Codecov Report
@@ Coverage Diff @@
## master #4238 +/- ##
==========================================
+ Coverage 78.73% 79.40% +0.66%
==========================================
Files 572 575 +3
Lines 12429 12593 +164
Branches 3068 3149 +81
==========================================
+ Hits 9786 9999 +213
+ Misses 2611 2564 -47
+ Partials 32 30 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a big one. Sorry in advance 😅
Missing a bunch of tests, possibly a LS migration, should follow more of our code standards and possibly just a bit more polish.
Let me know if you have any questions about any comments - I suspect we'll need to iterate a bit on this before merging 👍
Since the PR is large I asked Maarten to take a look as well.
src/components/TransactionFlow/displays/FaucetReceiptBanner.tsx
Outdated
Show resolved
Hide resolved
…g other requested changes
65ced7e
to
d76407c
Compare
Description
Makes changes to txReceipt types and make tx history panel and tx status panels more useful.
Changes
ITxReceipt
types to handle valueTransfers (so we can display more than one asset transfer in txhistory and txstatus panels at a time).mtime
s to be1234567891011
in fixtures, so it's easier to test against them.