refactor: do light merging later, remove ChunkProcessingPipeline #4879
+91
−1,010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Type: Refactoring
|
It is incorrect. (Parallel processing incorrect too. But i did it) Main pros:
I try to do this already :( |
|
@tolziplohu I know you had some questions about this. What should we do with this PR? Put it back in Draft status? |
It sounds like if chunks aren't marked ready until light merging happens, that would probably solve the problems @DarkWeird identified. I don't much time currently though, so I'll mark it as a draft for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
Most of the complexity around
ChunkProcessingPipelineis because of the need to support chunk tasks which require neighboring chunks. The only task which requires that is light merging, so this PR experiments with moving light merging to after the main chunk processing phase. This makes it so that chunks appear in the world immediately after their generated, but will have their lighting updated when neighboring chunks are generated, instead of waiting for the neighbors to generate to appear at all. It also meansChunkProcessingPipelinecan be removed entirely, and replaced with fairly simple usage of the Reactor APIs.How to test
Try generating a world, loading a world, playing in multiplayer. My multiplayer doesn't really seem to work right now anyway so I haven't tested whether this PR breaks it.
Outstanding before merging
Is there any reason besides light merging to support chunk tasks with multiple requirements? If so, the complexity might be worth it.