clustering_qr.kmeans_plusplus explicit tensors deletion #773
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand the reach of clear_cache to clustering_qr.kmeans_plusplus.
Somehow I still get OOM at
Kilosort/kilosort/clustering_qr.py
Line 202 in b2f5ded
The error happens with a specific Xg matrix that takes 5GB of GPU memory. I have 12GB of memory on my RTX 4070.
The explicit deletion of vexp and dexp will slow down the loop therefore happens only if the tensor is bigger than 4GB.
dexp and vexp are reassigned within each loop but somehow the GPU does not delete immediately the previous tensor. It is enough to delete the variables, it is not necessary to use directly torch.cuda.empty_cache(), that would further slow doen the loop.
Related to #746, possibly #771